Skip to content

Commit

Permalink
fix(gnovm): remove migration code of old GNOHOME (#2978)
Browse files Browse the repository at this point in the history 
closes #800 
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>
  • Loading branch information
@Villaquiranm
Villaquiranm authored Oct 18, 2024
1 parent e587167 commit 4d86229
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 59 deletions.
2 changes: 0 additions & 2 deletions gnovm/pkg/gnoenv/gnohome.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,5 @@ func HomeDir() string {
}
gnoHome := filepath.Join(dir, "gno")

// XXX: added april 2023 as a transitory measure - remove after test4
fixOldDefaultGnoHome(gnoHome)
return gnoHome
}
28 changes: 0 additions & 28 deletions gnovm/pkg/gnoenv/migration.go
View file

This file was deleted.

29 changes: 0 additions & 29 deletions gnovm/pkg/gnoenv/migration_test.go
View file

This file was deleted.

1 comment on commit 4d86229

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 4d86229 Previous: e587167 Ratio
BenchmarkBinary/EmptyStruct:encode 495.6 ns/op 96 B/op 2 allocs/op 291.4 ns/op 96 B/op 2 allocs/op 1.70
BenchmarkBinary/EmptyStruct:encode - ns/op 495.6 ns/op 291.4 ns/op 1.70
BenchmarkBinary/EmptyStruct:decode 293.3 ns/op 0 B/op 0 allocs/op 142.5 ns/op 0 B/op 0 allocs/op 2.06
BenchmarkBinary/EmptyStruct:decode - ns/op 293.3 ns/op 142.5 ns/op 2.06
BenchmarkBinary/PrimitivesStruct:encode 4934 ns/op 1724 B/op 60 allocs/op 4084 ns/op 1724 B/op 60 allocs/op 1.21
BenchmarkBinary/PrimitivesStruct:encode - ns/op 4934 ns/op 4084 ns/op 1.21
BenchmarkBinary/ShortArraysStruct:decode 431.7 ns/op 0 B/op 0 allocs/op 231.2 ns/op 0 B/op 0 allocs/op 1.87
BenchmarkBinary/ShortArraysStruct:decode - ns/op 431.7 ns/op 231.2 ns/op 1.87
BenchmarkRemoved 38.87 ns/op 0 B/op 0 allocs/op 29.22 ns/op 0 B/op 0 allocs/op 1.33
BenchmarkRemoved - ns/op 38.87 ns/op 29.22 ns/op 1.33
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 63792684 ns/op 5130 B/op 9 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 2.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 63792684 ns/op 31932145 ns/op 2.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 127812149 ns/op 5139 B/op 9 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 4.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 127812149 ns/op 31932145 ns/op 4.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 255601732 ns/op 5158 B/op 9 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 8.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 255601732 ns/op 31932145 ns/op 8.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 510082675 ns/op 5196 B/op 10 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 15.97
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 510082675 ns/op 31932145 ns/op 15.97
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 1020026239 ns/op 5528 B/op 13 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 31.94
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 1020026239 ns/op 31932145 ns/op 31.94
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 13 allocs/op 9 allocs/op 1.44
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 2039749703 ns/op 5528 B/op 13 allocs/op 31932145 ns/op 5125 B/op 9 allocs/op 63.88
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 2039749703 ns/op 31932145 ns/op 63.88
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 13 allocs/op 9 allocs/op 1.44
BenchmarkSigning 84426 ns/op 1856 B/op 36 allocs/op 25732 ns/op 64 B/op 1 allocs/op 3.28
BenchmarkSigning - ns/op 84426 ns/op 25732 ns/op 3.28
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkSigning 83518 ns/op 1856 B/op 36 allocs/op 25732 ns/op 64 B/op 1 allocs/op 3.25
BenchmarkSigning - ns/op 83518 ns/op 25732 ns/op 3.25
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkVerification 169322 ns/op 864 B/op 19 allocs/op 61330 ns/op 0 B/op 0 allocs/op 2.76
BenchmarkVerification - ns/op 169322 ns/op 61330 ns/op 2.76
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkVerification 164410 ns/op 864 B/op 19 allocs/op 61330 ns/op 0 B/op 0 allocs/op 2.68
BenchmarkVerification - ns/op 164410 ns/op 61330 ns/op 2.68
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkImmutableAvlTreeMemDB 5050169 ns/op 1081336 B/op 22009 allocs/op 3109589 ns/op 846791 B/op 17204 allocs/op 1.62
BenchmarkImmutableAvlTreeMemDB - ns/op 5050169 ns/op 3109589 ns/op 1.62
BenchmarkImmutableAvlTreeMemDB - B/op 1081336 B/op 846791 B/op 1.28
BenchmarkImmutableAvlTreeMemDB - allocs/op 22009 allocs/op 17204 allocs/op 1.28
BenchmarkRandomBytes/random 69.07 ns/op 16 B/op 1 allocs/op 32.88 ns/op 4 B/op 1 allocs/op 2.10
BenchmarkRandomBytes/random - ns/op 69.07 ns/op 32.88 ns/op 2.10
BenchmarkRandomBytes/random - B/op 16 B/op 4 B/op 4
BenchmarkRandomBytes/random 106.7 ns/op 32 B/op 1 allocs/op 32.88 ns/op 4 B/op 1 allocs/op 3.25
BenchmarkRandomBytes/random - ns/op 106.7 ns/op 32.88 ns/op 3.25
BenchmarkRandomBytes/random - B/op 32 B/op 4 B/op 8
BenchmarkRandomBytes/random 269 ns/op 112 B/op 1 allocs/op 32.88 ns/op 4 B/op 1 allocs/op 8.18
BenchmarkRandomBytes/random - ns/op 269 ns/op 32.88 ns/op 8.18
BenchmarkRandomBytes/random - B/op 112 B/op 4 B/op 28
BenchmarkRandomBytes/random 2360 ns/op 1024 B/op 1 allocs/op 32.88 ns/op 4 B/op 1 allocs/op 71.78
BenchmarkRandomBytes/random - ns/op 2360 ns/op 32.88 ns/op 71.78
BenchmarkRandomBytes/random - B/op 1024 B/op 4 B/op 256
BenchmarkSmall/boltdb-1000-100-16-40/update 1495219 ns/op 46036 B/op 408 allocs/op 961102 ns/op 37448 B/op 371 allocs/op 1.56
BenchmarkSmall/boltdb-1000-100-16-40/update - ns/op 1495219 ns/op 961102 ns/op 1.56
BenchmarkSmall/boltdb-1000-100-16-40/update - B/op 46036 B/op 37448 B/op 1.23
BenchmarkSmall/memdb-1000-100-16-40/block 18361454 ns/op 9120132 B/op 166103 allocs/op 12610159 ns/op 6574208 B/op 116695 allocs/op 1.46
BenchmarkSmall/memdb-1000-100-16-40/block - ns/op 18361454 ns/op 12610159 ns/op 1.46
BenchmarkSmall/memdb-1000-100-16-40/block - B/op 9120132 B/op 6574208 B/op 1.39
BenchmarkSmall/memdb-1000-100-16-40/block - allocs/op 166103 allocs/op 116695 allocs/op 1.42
BenchmarkMedium/boltdb-100000-100-16-40/update 6754215 ns/op 132880 B/op 1032 allocs/op 5514001 ns/op 102774 B/op 869 allocs/op 1.22
BenchmarkMedium/boltdb-100000-100-16-40/update - ns/op 6754215 ns/op 5514001 ns/op 1.22
BenchmarkMedium/boltdb-100000-100-16-40/update - B/op 132880 B/op 102774 B/op 1.29
BenchmarkMedium/memdb-100000-100-16-40/update - B/op 365768 B/op 251039 B/op 1.46
BenchmarkMedium/memdb-100000-100-16-40/update - allocs/op 7244 allocs/op 4835 allocs/op 1.50
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - B/op 48671 B/op 38930 B/op 1.25
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - allocs/op 582 allocs/op 451 allocs/op 1.29
BenchmarkLevelDBBatchSizes/goleveldb-100000-2000-16-40/block - B/op 99395078 B/op 79351734 B/op 1.25
BenchmarkLevelDBBatchSizes/goleveldb-100000-2000-16-40/block - allocs/op 1203261 allocs/op 995251 allocs/op 1.21
BenchmarkHash/ripemd160 2844 ns/op 25 B/op 1 allocs/op 702.6 ns/op 25 B/op 1 allocs/op 4.05
BenchmarkHash/ripemd160 - ns/op 2844 ns/op 702.6 ns/op 4.05
BenchmarkHash/sha2-256 524 ns/op 33 B/op 1 allocs/op 170.5 ns/op 33 B/op 1 allocs/op 3.07
BenchmarkHash/sha2-256 - ns/op 524 ns/op 170.5 ns/op 3.07
BenchmarkHash/sha3-256 1839 ns/op 33 B/op 1 allocs/op 715.6 ns/op 33 B/op 1 allocs/op 2.57
BenchmarkHash/sha3-256 - ns/op 1839 ns/op 715.6 ns/op 2.57
BenchmarkWriteSecretConnection 6274 ns/op 0 B/op 0 allocs/op 4024 ns/op 0 B/op 0 allocs/op 1.56
BenchmarkWriteSecretConnection - ns/op 6274 ns/op 4024 ns/op 1.56
BenchmarkReadSecretConnection 3584 ns/op 0 B/op 0 allocs/op 2362 ns/op 0 B/op 0 allocs/op 1.52
BenchmarkReadSecretConnection - ns/op 3584 ns/op 2362 ns/op 1.52

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ajnavarro @thehowl @zivkovicmilos

Please sign in to comment.