Skip to content

Commit

Permalink
ci(github-bot): remove up-to-date rule and reword ignore button (#3357)
Browse files Browse the repository at this point in the history
Related to
#3238 (comment) and
#3238 (comment)

This PR:
- remove the requirement `head branch must be up-to-date with its base`
- clarify the description of the checkbox used to ignore the bot
  • Loading branch information
aeddi authored Dec 17, 2024
1 parent ec40dc0 commit 0ae3f7a
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions contribs/github-bot/internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type ManualCheck struct {

// This is the description for a persistent rule with a non-standard behavior
// that allow maintainer to force the "success" state of the CI check
const ForceSkipDescription = "**SKIP**: Do not block the CI for this PR"
const ForceSkipDescription = "**IGNORE** the bot requirements for this PR (force green CI check)"

// This function returns the configuration of the bot consisting of automatic and manual checks
// in which the GitHub client is injected.
Expand All @@ -35,11 +35,6 @@ func Config(gh *client.GitHub) ([]AutomaticCheck, []ManualCheck) {
If: c.CreatedFromFork(),
Then: r.MaintainerCanModify(),
},
{
Description: "The pull request head branch must be up-to-date with its base ([more info](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch))",
If: c.Always(),
Then: r.UpToDateWith(gh, r.PR_BASE),
},
{
Description: "Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff",
If: c.FileChanged(gh, "^docs/"),
Expand Down

0 comments on commit 0ae3f7a

Please sign in to comment.