Avoid possible NPE, fixes apache#795

gnodet · Mar 9, 2023 · eed7a5f · eed7a5f
1 parent c1fd7e6
commit eed7a5f
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/daemon/src/main/java/org/mvndaemon/mvnd/logging/smart/LoggingExecutionListener.java b/daemon/src/main/java/org/mvndaemon/mvnd/logging/smart/LoggingExecutionListener.java
@@ -23,6 +23,7 @@
 
 import org.apache.maven.execution.ExecutionEvent;
 import org.apache.maven.execution.ExecutionListener;
+import org.apache.maven.execution.MavenExecutionRequest;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.execution.ProjectExecutionEvent;
 import org.apache.maven.execution.ProjectExecutionListener;
@@ -58,12 +59,23 @@ public void afterProjectExecutionSuccess(ProjectExecutionEvent projectExecutionE
     @Override
     public void afterProjectExecutionFailure(ProjectExecutionEvent projectExecutionEvent) {
         MavenSession session = projectExecutionEvent.getSession();
+        boolean halted;
+        // The ReactorBuildStatus is only available if the SmartBuilder is used
         ReactorBuildStatus status =
                 (ReactorBuildStatus) session.getRepositorySession().getData().get(ReactorBuildStatus.class);
+        if (status != null) {
+            halted = status.isHalted();
+        } else {
+            // assume sensible default
+            Throwable t = projectExecutionEvent.getCause();
+            halted = (t instanceof RuntimeException || !(t instanceof Exception))
+                || !MavenExecutionRequest.REACTOR_FAIL_NEVER.equals(session.getReactorFailureBehavior())
+                && !MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior());
+        }
         Throwable cause = projectExecutionEvent.getCause();
         buildEventListener.executionFailure(
                 projectExecutionEvent.getProject().getArtifactId(),
-                status.isHalted(),
+                halted,
                 cause != null ? cause.toString() : null);
     }