Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[module] MODULE_IMPORT_NS now requires a string literal in 6.13 #1149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ticpu
Copy link

@ticpu ticpu commented Dec 30, 2024

Reference torvalds/linux@cdd30ebb1

Using a string literal still compiles on 6.11

@Svenum
Copy link

Svenum commented Jan 27, 2025

Some news here? I am waiting for this PR

@ticpu ticpu force-pushed the master branch 3 times, most recently from 92a26f0 to 4251a5c Compare February 4, 2025 00:16
@ticpu
Copy link
Author

ticpu commented Feb 4, 2025

@netboy3 for what it's worth, I updated my PR, thanks for the helpful review on zeule's PR.

@HikariKnight
Copy link

HikariKnight commented Feb 23, 2025

@ticpu i would suggest that you use if statements for the kernel module fix for 6.13 as this current patch breaks when building against kernel 6.12.X and older kernels for fedora atomic

--- a/module/kvmfr.c
+++ b/module/kvmfr.c
@@ -654,7 +654,9 @@ MODULE_DEVICE_TABLE(pci, kvmfr_pci_ids);
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Geoffrey McRae <[email protected]>");
 MODULE_AUTHOR("Guanzhong Chen <[email protected]>");
-MODULE_VERSION("0.0.9");
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,16,0)
+MODULE_VERSION("0.0.12");
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,13,0)
+MODULE_IMPORT_NS("DMA_BUF");
+#elif LINUX_VERSION_CODE >= KERNEL_VERSION(5,16,0)
 MODULE_IMPORT_NS(DMA_BUF);
 #endif

@ticpu
Copy link
Author

ticpu commented Feb 23, 2025

@ticpu i would suggest that you use if statements for the kernel module fix for 6.13 as this current patch breaks when building against kernel 6.12.X and older kernels on fedora

I wonder if it's something specific to Fedora or Arch as this is supposed to be compatible for a long time. Like I said in my first post, it did compile or Arch's 6.11.
Thanks for the tip I'll check it out tonight.

@HikariKnight
Copy link

@ticpu i would suggest that you use if statements for the kernel module fix for 6.13 as this current patch breaks when building against kernel 6.12.X and older kernels on fedora

I wonder if it's something specific to Fedora or Arch as this is supposed to be compatible for a long time. Like I said in my first post, it did compile or Arch's 6.11. Thanks for the tip I'll check it out tonight.

you are welcome, it is probably a good idea to keep the old behavior on anything that is not 6.13+

Fixes: gnif#1155
References: 33def8498fdde180023444b08e12b72a9efed41d
Co-authored-by: HikariKnightt <[email protected]>
Co-authored-by: zeule <[email protected]>
Reviewed-by: netboy3 <[email protected]>
@ticpu
Copy link
Author

ticpu commented Feb 24, 2025

Since I was mislead with my v6.11 build on ArchLinux, I decided to test it out with multiple kernels.

Without the patch, anything below 6.13-rc1 fails.

With #if'ed patch, I could build the module on vanilla 6.10, 6.14-rc1, Fedora's 6.12 and ArchLinux's 6.13.

I added both zeule and you as co-author since you both suggested to add the #if in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants