-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[module] MODULE_IMPORT_NS now requires a string literal in 6.13 #1149
base: master
Are you sure you want to change the base?
Conversation
Some news here? I am waiting for this PR |
92a26f0
to
4251a5c
Compare
@netboy3 for what it's worth, I updated my PR, thanks for the helpful review on zeule's PR. |
@ticpu i would suggest that you use if statements for the kernel module fix for 6.13 as this current patch breaks when building against kernel 6.12.X and older kernels for fedora atomic --- a/module/kvmfr.c
+++ b/module/kvmfr.c
@@ -654,7 +654,9 @@ MODULE_DEVICE_TABLE(pci, kvmfr_pci_ids);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Geoffrey McRae <[email protected]>");
MODULE_AUTHOR("Guanzhong Chen <[email protected]>");
-MODULE_VERSION("0.0.9");
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,16,0)
+MODULE_VERSION("0.0.12");
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,13,0)
+MODULE_IMPORT_NS("DMA_BUF");
+#elif LINUX_VERSION_CODE >= KERNEL_VERSION(5,16,0)
MODULE_IMPORT_NS(DMA_BUF);
#endif |
I wonder if it's something specific to Fedora or Arch as this is supposed to be compatible for a long time. Like I said in my first post, it did compile or Arch's 6.11. |
you are welcome, it is probably a good idea to keep the old behavior on anything that is not 6.13+ |
Fixes: gnif#1155 References: 33def8498fdde180023444b08e12b72a9efed41d Co-authored-by: HikariKnightt <[email protected]> Co-authored-by: zeule <[email protected]> Reviewed-by: netboy3 <[email protected]>
Since I was mislead with my v6.11 build on ArchLinux, I decided to test it out with multiple kernels. Without the patch, anything below 6.13-rc1 fails. With #if'ed patch, I could build the module on vanilla 6.10, 6.14-rc1, Fedora's 6.12 and ArchLinux's 6.13. I added both zeule and you as co-author since you both suggested to add the |
Reference torvalds/linux@cdd30ebb1
Using a string literal still compiles on 6.11