Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem with the mouse scrolling when switching from X11 + i3 to Wayland + Hyprland. At first I thought that this might be due to an outdated version of Looking Glass, as I was still using version B6 in my gaming VM. However, I performed a clean installation of my system last night, set up a new VM , but the problem was still there - even with the bleeding edge version.
Actual problem
I've noticed that the actual value of the
value
parameter inpointerAxisHandler
is sometimes0
while scrolling up or down. After looking at the implementation, you'll see why.Since the
value
is not greater than0
, the LookinGlass client will always handle the event asSPICE_MOUSE_BUTTON_UP
.Preview
https://i.imgur.com/A7eGpMb.mp4
Logs
Solution
I've added an OR statement to the condition so that the events are only processed if the value is not
0
.