-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accurate placement protocol V3 support (For Crafter Rotations) #323
Open
sakura-ryoko
wants to merge
9
commits into
gnembon:master
Choose a base branch
from
sakura-ryoko:1.21-accurate_placement_v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
accurate placement protocol V3 support (For Crafter Rotations) #323
sakura-ryoko
wants to merge
9
commits into
gnembon:master
from
sakura-ryoko:1.21-accurate_placement_v3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sakura-ryoko
commented
Jun 30, 2024
•
edited
Loading
edited
- Add accuratePlacementProtocol V3 to support Crafter Rotations, and other Block States on the White list.
- Code was originally written by masa.
Crystal0404
reviewed
Jul 8, 2024
Found another issue |
Merge from upstream for 1.21.1
I moved this config back to a Boolean, and added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.