fixed security typing

gmmorris · Jul 1, 2020 · 036a082 · 036a082
1 parent 90d0df4
commit 036a082
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/x-pack/plugins/alerts/server/authorization/alerts_authorization.ts b/x-pack/plugins/alerts/server/authorization/alerts_authorization.ts
@@ -7,6 +7,7 @@
 import Boom from 'boom';
 import { pluck, mapValues, remove, omit, isUndefined } from 'lodash';
 import { KibanaRequest } from 'src/core/server';
+import { RecursiveReadonly } from '@kbn/utility-types';
 import { ALERTS_FEATURE_ID } from '../../common';
 import { AlertTypeRegistry } from '../types';
 import { SecurityPluginSetup } from '../../../security/server';
@@ -316,7 +317,9 @@ export function ensureFieldIsSafeForQuery(field: string, value: string): boolean
 }
 
 function hasAnyAlertingPrivileges(
-  privileges?: FeatureKibanaPrivileges | SubFeaturePrivilegeConfig
+  privileges?:
+    | RecursiveReadonly<FeatureKibanaPrivileges>
+    | RecursiveReadonly<SubFeaturePrivilegeConfig>
 ): boolean {
   return (
     ((privileges?.alerting?.all?.length ?? 0) || (privileges?.alerting?.read?.length ?? 0)) > 0

diff --git a/x-pack/plugins/features/common/feature_kibana_privileges.ts b/x-pack/plugins/features/common/feature_kibana_privileges.ts
@@ -90,7 +90,7 @@ export interface FeatureKibanaPrivileges {
      *  }
      * ```
      */
-    all?: string[];
+    all?: readonly string[];
 
     /**
      * List of alert types which users should have read-only access to when granted this privilege.
@@ -101,7 +101,7 @@ export interface FeatureKibanaPrivileges {
      *  }
      * ```
      */
-    read?: string[];
+    read?: readonly string[];
   };
   /**
    * If your feature requires access to specific saved objects, then specify your access needs here.

diff --git a/...ck/plugins/security/server/authorization/privileges/feature_privilege_builder/alerting.ts b/...ck/plugins/security/server/authorization/privileges/feature_privilege_builder/alerting.ts
@@ -27,7 +27,7 @@ export class FeaturePrivilegeAlertingBuilder extends BaseFeaturePrivilegeBuilder
   public getActions(privilegeDefinition: FeatureKibanaPrivileges, feature: Feature): string[] {
     const getAlertingPrivilege = (
       operations: string[],
-      privilegedTypes: string[],
+      privilegedTypes: readonly string[],
       consumer: string
     ) =>
       privilegedTypes.flatMap((type) =>