fix upload artifact

gmgigi96 · Oct 6, 2023 · 5ea82d3 · 5ea82d3
1 parent 00e7a40
commit 5ea82d3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/compose.yml b/.github/workflows/compose.yml
@@ -6,7 +6,6 @@ on:
         required: true
         type: string
       image:
-        required: true
         type: string
       submodules:
         type: boolean
@@ -25,6 +24,7 @@ jobs:
           submodules: ${{ inputs.submodules }}
       - name: Download image
         uses: ishworkh/docker-image-artifact-download@v1
+        if: ${{ inputs.image != "" }}
         with:
           image: ${{ inputs.image }}
       - name: Test

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -86,14 +86,12 @@ jobs:
     uses: ./.github/workflows/compose.yml
     with:
       test: ${{ matrix.test }}
-      image: ${{ needs.docker-revad.outputs.image }}
   acceptance-1:
     needs:
       - docker-revad-eos
     uses: ./.github/workflows/compose.yml
     with:
       test: acceptance-1
-      image: ${{ needs.docker-revad.outputs.image }}
       submodules: true
   acceptance-2:
     needs:
@@ -105,7 +103,6 @@ jobs:
     uses: ./.github/workflows/compose.yml
     with:
       test: acceptance-2
-      image: ${{ needs.docker-revad.outputs.image }}
       submodules: true
       parts: 6
       part: ${{ matrix.part }}
diff --git a/tests/docker/docker-compose.yml b/tests/docker/docker-compose.yml
@@ -1,10 +1,12 @@
 version: "3.4"
 services:
   revad:
-    image: ${REVAD_IMAGE}
-    # build: 
-    #   context: ../../
-    #   dockerfile: docker/Dockerfile.revad-eos
+    # image: ${REVAD_IMAGE}
+    # we build the reva image with eos because it's faster
+    # instead of uploading and share through the github runners
+    build: 
+      context: ../../
+      dockerfile: docker/Dockerfile.revad-eos
     volumes:
       - ../revad:/etc/revad
     working_dir: /etc/revad/