build: remove --depth 1 from git clone in Dockerfile #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clones the full branch of the flutter version tag instead of only the latest commit.
Why
The version 3.29.0 uses git when running the flutter CLI and that is causing fatal: Not a valid object name origin/master
That is reported in flutter/flutter#163198 and due to the usage of the git CLI as
git -C "$FLUTTER_ROOT" merge-base HEAD origin/master
in https://github.com/flutter/flutter/blob/87196771eb0119ffc9d23a644bd4209eb19d5eef/bin/internal/update_engine_version.sh#L50