Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pacmd_muted_value" option cannot be set because of typo in util.py #43

Closed
theArchLadder opened this issue Mar 27, 2015 · 1 comment
Closed

Comments

@theArchLadder
Copy link

There is a typo near the end of line 121 in util.py:
-"pamcd_muted_value"
+"pacmd_muted_value"

Without this option blockify can mute, but not unmute, if language is non-english.
I need this option to get blockify to work, i have changed this typo and built blockify, and it works for me.

This issue is related to #38

I guess one ugly solution to not require this option could be to just unmute and read the pacmd "muted" value at the start of blockify
Out of curiosity, why is there a need to check if spotify is muted or not, if there is an ad running, mute, if not, unmute, right? No?

BTW, thanks for this awesome application :)

@gmdfalk
Copy link
Owner

gmdfalk commented Mar 27, 2015

Hey,

thanks, I'll fix that.

To answer your question, mute state information is used by the GUI. I agree it's not ideal since mute state is determined by spawning subprocesses and reading output from external unix binaries like pacmd or amixer.

I like your suggestion to force unmute, then read the "muted" value at the start. If you'd like, feel free to implement that and submit a pull request. Otherwise, i'll do it but with some delay since i'm going on vacation ;)

Regards

gmdfalk pushed a commit that referenced this issue Mar 27, 2015
@gmdfalk gmdfalk closed this as completed Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants