Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kotlin Multiplatform support with a Compiler plugin #46

Merged
merged 29 commits into from
Dec 25, 2023
Merged

Conversation

gmazzo
Copy link
Owner

@gmazzo gmazzo commented Dec 3, 2023

Now the plugin is split into 3, each one providing a different set of features and targeting different use cases:

  1. The io.github.gmazzo.codeowners plugin adds a Gradle report of classes' ownership
  2. The io.github.gmazzo.codeowners.jvm plugin propagates the classes' ownership information to runtime. It supports any JVM build (java, groovy, etc) that produces .class files, but JVM-only
  3. The io.github.gmazzo.codeowners.kotlin Kotlin Compiler plugin propagates the classes' ownership information to runtime. It supports any Kotlin build (jvm, android, multiplatform, etc, but Kotlin-only)

@gmazzo gmazzo force-pushed the kmp-support branch 2 times, most recently from 8a80acb to 5a17de1 Compare December 3, 2023 16:30
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (80a249a) 78.40% compared to head (768d8c6) 76.79%.
Report is 2 commits behind head on main.

❗ Current head 768d8c6 differs from pull request most recent head 26dec61. Consider uploading reports for the commit 26dec61 to get more accurate results

Files Patch % Lines
...hub/gmazzo/codeowners/matcher/CodeOwnersMatcher.kt 0.00% 10 Missing ⚠️
...io/github/gmazzo/codeowners/CodeOwnersJVMPlugin.kt 85.71% 2 Missing ⚠️
...tlin/io/github/gmazzo/codeowners/CodeOwnersTask.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
- Coverage     78.40%   76.79%   -1.62%     
+ Complexity       51       39      -12     
============================================
  Files             7        7              
  Lines           389      349      -40     
  Branches         64       57       -7     
============================================
- Hits            305      268      -37     
- Misses           59       63       +4     
+ Partials         25       18       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmazzo gmazzo force-pushed the kmp-support branch 2 times, most recently from 0309426 to e06666a Compare December 11, 2023 07:35
@gmazzo gmazzo force-pushed the kmp-support branch 10 times, most recently from 08abf5d to d258477 Compare December 24, 2023 15:03
@gmazzo gmazzo force-pushed the kmp-support branch 2 times, most recently from a52dcd3 to cf07f13 Compare December 25, 2023 18:21
@gmazzo gmazzo marked this pull request as ready for review December 25, 2023 21:10
@gmazzo gmazzo enabled auto-merge (rebase) December 25, 2023 21:10
@gmazzo gmazzo merged commit 99a64cf into main Dec 25, 2023
3 checks passed
@gmazzo gmazzo deleted the kmp-support branch December 25, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant