Fix storage-stack.yaml

1. Change the type of `SubnetThree` from `AWS::EC2::Subnet::Id` to `String` to allow empty value. 2. Add `cfn-lint` for the template Signed-off-by: Hanwen <[email protected]>
gmarciani · Oct 1, 2024 · 625d9e0 · 625d9e0
1 parent df041cd
commit 625d9e0
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/cli/tox.ini b/cli/tox.ini
@@ -221,6 +221,7 @@ changedir =
 deps = cfn-lint
 commands =
     cfn-lint --info networking/*.cfn.json
+    cfn-lint --non-zero-exit-code error */*.yaml
 
 # Validates that cfn json templates are correctly formatted.
 [testenv:cfn-format-check]

diff --git a/cloudformation/database/serverless-database.yaml b/cloudformation/database/serverless-database.yaml
@@ -40,6 +40,10 @@ Metadata:
         default: "The CIDR block to be used for the first Subnet if its creation is requested."
       Subnet2CidrBlock:
         default: "The CIDR block to be used for the second Subnet if its creation is requested."
+  cfn-lint:
+    config:
+      ignore_checks:
+        - E3690
 Parameters:
   ClusterName:
     Description: Database Cluster Name

diff --git a/cloudformation/proxy/proxy.yaml b/cloudformation/proxy/proxy.yaml
@@ -28,6 +28,10 @@ Metadata:
           default: Permissions
         Parameters:
           - Keypair
+  cfn-lint:
+    config:
+      ignore_checks:
+        - E1152
 
 Resources:
 

diff --git a/cloudformation/storage/storage-stack.yaml b/cloudformation/storage/storage-stack.yaml
@@ -75,7 +75,8 @@ Parameters:
     Default: ''
   SubnetThree:
     Description: ID of the Subnet (third Availability Zone) where the storage will be deployed.
-    Type: AWS::EC2::Subnet::Id
+    # The type has to be String to allow empty values.
+    Type: String
     Default: ''
   EbsVolumeAz:
     Description: AZ where the EBS Volume will be deployed. It must be the same AZ used by the cluster head node.