Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFR: Set the value of lock ->release to true when lock ->owners is empty #4094

Closed
wants to merge 1 commit into from

Conversation

JamesWSWu
Copy link
Contributor

@JamesWSWu JamesWSWu commented Apr 3, 2023

In the afr_writev_wind_cbk process, when lock ->owners is empty, set the value of lock ->release to true .
So that in the following AFR_ writev_unwrind process, the fuse process does not crash in debug mode.

Fixes: #4091

Signed-off-by: JamesWSWu

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@JamesWSWu
Copy link
Contributor Author

@xhernandez

@xhernandez
Copy link
Contributor

I think this is not the right approach (setting acquired to false when the lock is actually acquired will probably have some bad consequences at some point). However this logic is very delicate and it will be better reviewed by who created it. @karthik-us @pranithk can you take a look ?

@rms007-sh
Copy link

rms007-sh commented Apr 7, 2023

same as #3065 @karthik-us @pranithk @xhernandez

Signed-off-by: 10255046 <[email protected]>
@JamesWSWu JamesWSWu changed the title AFR: Set the value of lock ->acquire to false when lock ->owners is empty AFR: Set the value of lock ->release to true when lock ->owners is empty Apr 7, 2023
@JamesWSWu
Copy link
Contributor Author

@karthik-us @pranithk could you take a look ?

1 similar comment
@JamesWSWu
Copy link
Contributor Author

@karthik-us @pranithk could you take a look ?

@JamesWSWu JamesWSWu closed this Jun 19, 2023
@JamesWSWu JamesWSWu deleted the issue4091 branch August 1, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In debug mode, the fuse process crashes in GF_ ASSERT(!(*take_lock))
4 participants