Allow using non-SVG icons in toolbar #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the way the Jupyter toolbar is set up, we can only use SVG icons. This is usually fine, as most of our glue-core icons are available as both png or svg. However, there are some icons (the rotation icon in the vispy viewers, for example) for which we only have pngs.
This PR updates the format that gets passed to
icon_path
to depend on the path for the icon. If a valid image MIME type can't be determined, then it raises an error.