Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ipyvolume viewer issues #456

Merged
merged 8 commits into from
Aug 6, 2024
+33 −22
Merged

Updates for ipyvolume viewer issues #456

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b1b906
Update layer artist to work with ZXY data convention.
Carifio24 Jun 28, 2024
80a9083
Update figure limits and comment.
Carifio24 Jul 2, 2024
276e2b3
Update scatter labels test
Carifio24 Jul 2, 2024
de0c6ef
Update limit attribute checks.
Carifio24 Jul 25, 2024
2d81936
Apply similar coordinate changes to scatter viewer.
Carifio24 Jul 25, 2024
9b9fe63
Update scatter tests to match axis updates.
Carifio24 Jul 25, 2024
cc06fd3
Cast scatter data to floats if necessary.
Carifio24 Aug 1, 2024
d479fe9
Codestyle fixes.
Carifio24 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update scatter tests to match axis updates.
@Carifio24
Carifio24 committed Jul 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 9b9fe631fa56164d9c0b5c5addc5030c8c4f43ec
8 changes: 4 additions & 4 deletions glue_jupyter/ipyvolume/tests/test_ipyvolume.py
View file
Original file line number Diff line number Diff line change
@@ -36,16 +36,16 @@ def test_scatter3d(app, dataxyz, dataxz):
assert s.layers[1].layer['y'].tolist() == [4]
assert s.layers[1].layer['z'].tolist() == [7]

assert s.layers[1].scatter.x.tolist() == [1, 2, 3]
assert s.layers[1].scatter.z.tolist() == [2, 3, 4]
assert s.layers[1].scatter.z.tolist() == [1, 2, 3]
assert s.layers[1].scatter.x.tolist() == [2, 3, 4]
assert s.layers[1].scatter.y.tolist() == [5, 6, 7]
assert s.layers[1].scatter.selected == [2]

s.state.x_att = dataxyz.id['y']
s.state.y_att = dataxyz.id['z']
s.state.z_att = dataxyz.id['x']
assert s.layers[1].scatter.x.tolist() == [2, 3, 4]
assert s.layers[1].scatter.z.tolist() == [5, 6, 7]
assert s.layers[1].scatter.z.tolist() == [2, 3, 4]
assert s.layers[1].scatter.x.tolist() == [5, 6, 7]
assert s.layers[1].scatter.y.tolist() == [1, 2, 3]
assert s.layers[1].scatter.selected == [2]

Unchanged files with check annotations Beta

View file
glue_jupyter/common/state3d.py
# TODO: this could be cached based on the limits, but is not urgent
aspect = np.array([1, 1, 1], dtype=float)
if self.native_aspect:
aspect[0] = 1.0

Check warning on line 88 in glue_jupyter/common/state3d.py

Codecov / codecov/patch

glue_jupyter/common/state3d.py#L88 

Added line #L88 was not covered by tests
aspect[1] = (self.z_max - self.z_min) / (self.x_max - self.x_min)
aspect[2] = (self.y_max - self.y_min) / (self.x_max - self.x_min)
aspect /= aspect.max()