Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bqplot-gl to install_requires #385

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Aug 15, 2023

Description

Follow-up to #302; this will be needed once bqplot 0.13 is out, which is currently in alpha.
As discussed in #377 with the placeholder package bqplot-gl 0.0.0 available, this can be added to the requirements.
If someone has a bqplot>=0.13.0a0 installed, they will need to manually pick the alpha version or directly install
'bqplot-gl==0.1.0a0 first.

@dhomeier dhomeier added bqplot-viewers no-changelog-entry-needed Skipped in Changelog generation labels Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0be614f) 86.91% compared to head (b86c76a) 86.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          89       89           
  Lines        4990     4990           
=======================================
  Hits         4337     4337           
  Misses        653      653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhomeier dhomeier merged commit 05032ee into glue-viz:main Aug 16, 2023
@dhomeier dhomeier deleted the require-bqplot-gl branch August 16, 2023 15:44
@pllim
Copy link
Contributor

pllim commented Aug 29, 2023

@dhomeier , can you at least do a pre-release with this patch, so running Jdaviz with pre-releases do not crash?

See https://github.com/spacetelescope/jdaviz/actions/runs/6010161651/job/16301044292

bqplot==0.13.0a0
...
glue_jupyter/bqplot/compatibility.py:8: in <module>
    import bqplot_gl
E   ModuleNotFoundError: No module named 'bqplot_gl'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bqplot-viewers no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants