Fix panic on data slice accesses #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could easily happen if the binary data for the glTF was too short or empty. Ideally should return a `Result` and enum error for this rather than just `Option::None` but this is a pretty easy change at least and better than panicking.
This was referenced Oct 1, 2022
|
lgtm |
|
Can you please either allow edits from maintainers or cherry-pick d54a74a |
Cherrypicked from d54a74a by @IcanDivideBy0 Co-authored-by: Samuel Hurel <[email protected]>
|
thanks! resolved |
|
thank you |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could easily happen if the binary data for the glTF was too short or empty.
Ideally should return a
Resultand enum error for this rather than justOption::Nonebut this is a pretty easy change at least and better than panicking.Part of #359