Add sparse accessor iterators #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alteous
commented
Aug 19, 2019
src/accessor/util.rs
Outdated
| fn buffer_view_slice<'a, 's, F>(view: buffer::View<'a>, get_buffer_data: F) -> &'s [u8] | ||
| where F: Fn(buffer::Buffer<'a>) -> Option<&'s [u8]>, | ||
| { | ||
| let big_slice = get_buffer_data(view.buffer()).unwrap(); // TODO: don't unwrap() |
There was a problem hiding this comment.
TODO: don't unwrap()
Fix me
|
|
||
| /// General iterator for an accessor. | ||
| #[derive(Clone, Debug)] | ||
| pub enum Iter<'a, T: Item> { |
There was a problem hiding this comment.
Consider making Accessor an enum too
src/accessor/util.rs
Outdated
| where F: Clone + Fn(buffer::Buffer<'a>) -> Option<&'s [u8]>, | ||
| { | ||
| let is_sparse = accessor.sparse().is_some(); | ||
| Some(if is_sparse { |
There was a problem hiding this comment.
Some(
Fix me: return None if get_buffer_data fails.
alteous
force-pushed
the
sparse-accessor
branch
from
631fc05 to
3ee6472
Compare
alteous
force-pushed
the
sparse-accessor
branch
from
3ee6472 to
69f6de1
Compare
alteous
force-pushed
the
sparse-accessor
branch
from
69f6de1 to
16d807e
Compare
aloucks
added a commit
to aloucks/gltf
that referenced
this pull request
Nov 17, 2019
This trait was implemented for `Iter` prior to 0.14. It appears that the missing trait implementation was an oversight when sparse accessors were implemented in gltf-rs#246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154