Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 4.1 #244

Merged
merged 5 commits into from
May 27, 2017
Merged

Upgrade to Rails 4.1 #244

merged 5 commits into from
May 27, 2017

Commits on May 24, 2017

  1. Upgrade to Rails 4.1

    @Throne3d
    Throne3d committed May 24, 2017
    Configuration menu
    Copy the full SHA
    5949e1a View commit details
    Browse the repository at this point in the history

  2. Fix .count with .select in light of Rails 4.1 change 

    See rails/rails#10710
    @Throne3d
    Throne3d committed May 24, 2017
    Configuration menu
    Copy the full SHA
    3e03e37 View commit details
    Browse the repository at this point in the history

  3. Update to not use destructive in-line 'select!' on relation

    @Throne3d
    Throne3d committed May 24, 2017
    Configuration menu
    Copy the full SHA
    1862d2a View commit details
    Browse the repository at this point in the history

  4. Set cookies_serializer to allow transparent upgrade to JSON 

    This file is explicitly mentioned in the 4.0 -> 4.1 upgrade
and it says if you want to use the new JSON format to set
:hybrid here, to transparently migrate cookies; I'm not sure
if this file was just ignored before, and we weren't using
JSON, or what?

If I run the server without this change it crashes when I try
loading the site, and with this change it works.
    @Throne3d
    Throne3d committed May 24, 2017
    Configuration menu
    Copy the full SHA
    906de23 View commit details
    Browse the repository at this point in the history

  5. Use has_many :through relation for galleries and icons 

    (Fix recognizing galleries_icons relation with protected attributes)
    @Throne3d
    Throne3d committed May 24, 2017
    Configuration menu
    Copy the full SHA
    18134a5 View commit details
    Browse the repository at this point in the history