Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jinja2 block around memory options #831

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Add jinja2 block around memory options #831

merged 2 commits into from
Mar 18, 2024

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Mar 14, 2024

Motivation and Context

This is to enable overriding --mem with --mem-per-gpu or other cluster-specific options.
See discussion at #819 (comment)

Checklist:

This is to enable overriding --mem with --mem-per-gpu or other
cluster-specific options.
@cbkerr cbkerr requested review from a team as code owners March 14, 2024 21:27
@cbkerr cbkerr requested review from b-butler and iblanco11981870 and removed request for a team March 14, 2024 21:27
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bcrawford39GT this should allow you override the --mem in the next release of signac without waiting for #819.

@cbkerr cbkerr merged commit 525ec4c into main Mar 18, 2024
9 checks passed
@cbkerr cbkerr deleted the feat/memory-block branch March 18, 2024 13:55
@cbkerr cbkerr added this to the v0.29.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants