✨Make guidance spectra a first class citizen (Sourcery refactored) #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
requested review from
joernweissenborn and
jsnel
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
|
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight) |
sourcery-ai
bot
changed the title
sourcery-ai
bot
force-pushed
the
sourcery/pull-983
branch
from
f3bf175 to
67ffc5a
Compare
Codecov Report
@@ Coverage Diff @@
## main #984 +/- ##
=======================================
- Coverage 85.9% 85.7% -0.3%
=======================================
Files 92 93 +1
Lines 4972 5002 +30
Branches 937 942 +5
=======================================
+ Hits 4272 4287 +15
- Misses 552 564 +12
- Partials 148 151 +3
Continue to review full report at Codecov.
|
Co-authored-by: Jörn Weißenborn <[email protected]> Co-authored-by: Joris Snellenburg <[email protected]>
…}_dimension So they won't conflict with the method which has the same name
overwrite_{model|global}_dimension
♻️ Renamed methods overwrite_{model|global}_dimension to replace_{model|global}_dimension
to set_{model|global}_dimension
sourcery-ai
bot
force-pushed
the
sourcery/pull-983
branch
from
67ffc5a to
a7c1cd9
Compare
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.18%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #983 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!