-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇👌 Run Doxygen workflow only on 'workflow_dispatch' #981
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
=====================================
Coverage 85.6% 85.6%
=====================================
Files 90 90
Lines 4909 4909
Branches 927 927
=====================================
Hits 4207 4207
Misses 552 552
Partials 150 150 Continue to review full report at Codecov.
|
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
,👌
As requested by @jsnel this changes the Doxygen workflow to truly only run when requested.
The problem with the current implementation (#979 ) via github environment is that the UI never gets to the finished green checkmark state, but waits forever for the workflow to be approved.
This makes it hard to spot which PR is ready to be merged in the PR overview.
The new implementation allows specifying a repository to build the oxygen docs for (default
glotaran/pyglotaran
but could also be a fork) and a pr nr (default "" which uses the branch used to dispatch the workflow from).Change summary
Checklist