-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add Python 3.10 support #977
Conversation
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
=====================================
Coverage 85.6% 85.6%
=====================================
Files 90 90
Lines 4883 4909 +26
Branches 916 927 +11
=====================================
+ Hits 4181 4207 +26
Misses 552 552
Partials 150 150
Continue to review full report at Codecov.
|
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Using an old version of setuptools caused a lot of import errors in python 3.10 Pinning the version of setuptools goes back to the time when we still had c-extensions, so it is save to unpin it
aac1e36
to
1d5cc33
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It's about time. 😅
Numba 0.55.0 added support for python 3.10 which means so can we
Change summary
setuptools
Using an old version of
setuptools
caused a lot of import errors in python 3.10Pinning the version of
setuptools
goes back to the time when we still had c-extensions, so it is safe to unpin itChecklist