-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧🚇 Exclude test files from duplication checks on sonarcloud #959
Conversation
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
=====================================
Coverage 85.4% 85.4%
=====================================
Files 87 87
Lines 4874 4874
Branches 921 921
=====================================
Hits 4163 4163
Misses 559 559
Partials 152 152 Continue to review full report at Codecov.
|
📚 As future reference where to find the config options, this is the page in their docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. 👍
Due to duplications that aren't even part of a PR sonarcloud is failing its test (e.g. #958 )
By adding the test files which should be verbose and readable, I hope we can get around this issue.
Change summary
Checklist