Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧🚇 Exclude test files from duplication checks on sonarcloud #959

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jan 16, 2022

Due to duplications that aren't even part of a PR sonarcloud is failing its test (e.g. #958 )

image

image

By adding the test files which should be verbose and readable, I hope we can get around this issue.

Change summary

  • 🔧 Exclude test files from duplication checks

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)

@s-weigand s-weigand added the Type: Tooling Tools used for the project (CI, CD, docs etc.) label Jan 16, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/configure-sonarcloud

@s-weigand
Copy link
Member Author

Much better ^^
image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [96b42630]       [cc416a15]
     <v0.5.1>                   
       53.0±0.5ms       52.9±0.3ms     1.00  BenchmarkOptimize.time_optimize(False, False, False)
        96.1±40ms         57.3±1ms    ~0.60  BenchmarkOptimize.time_optimize(False, False, True)
       52.9±0.3ms       53.1±0.5ms     1.00  BenchmarkOptimize.time_optimize(False, True, False)
       56.8±0.2ms        57.8±30ms     1.02  BenchmarkOptimize.time_optimize(False, True, True)
       64.5±0.3ms       64.6±0.4ms     1.00  BenchmarkOptimize.time_optimize(True, False, False)
        68.8±30ms        68.3±30ms     0.99  BenchmarkOptimize.time_optimize(True, False, True)
       65.1±0.5ms       64.7±0.3ms     0.99  BenchmarkOptimize.time_optimize(True, True, False)
        68.9±30ms        69.0±30ms     1.00  BenchmarkOptimize.time_optimize(True, True, True)
             201M             198M     0.99  IntegrationTwoDatasets.peakmem_optimize
       1.83±0.06s       1.74±0.03s     0.95  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [86ed99fb]       [cc416a15]
       53.1±0.6ms       52.9±0.3ms     1.00  BenchmarkOptimize.time_optimize(False, False, False)
         57.2±6ms         57.3±1ms     1.00  BenchmarkOptimize.time_optimize(False, False, True)
       52.6±0.2ms       53.1±0.5ms     1.01  BenchmarkOptimize.time_optimize(False, True, False)
       56.7±0.5ms        57.8±30ms     1.02  BenchmarkOptimize.time_optimize(False, True, True)
       64.6±0.2ms       64.6±0.4ms     1.00  BenchmarkOptimize.time_optimize(True, False, False)
       68.6±0.4ms        68.3±30ms     1.00  BenchmarkOptimize.time_optimize(True, False, True)
       64.3±0.3ms       64.7±0.3ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
         68.1±4ms        69.0±30ms     1.01  BenchmarkOptimize.time_optimize(True, True, True)
             200M             198M     0.99  IntegrationTwoDatasets.peakmem_optimize
       1.72±0.06s       1.74±0.03s     1.01  IntegrationTwoDatasets.time_optimize

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #959 (cc416a1) into main (86ed99f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #959   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files         87      87           
  Lines       4874    4874           
  Branches     921     921           
=====================================
  Hits        4163    4163           
  Misses       559     559           
  Partials     152     152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ed99f...cc416a1. Read the comment docs.

@s-weigand
Copy link
Member Author

s-weigand commented Jan 16, 2022

📚 As future reference where to find the config options, this is the page in their docs

@s-weigand s-weigand requested a review from jsnel January 16, 2022 20:01
@s-weigand s-weigand marked this pull request as ready for review January 16, 2022 20:03
@s-weigand s-weigand requested a review from a team as a code owner January 16, 2022 20:03
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. 👍

@jsnel jsnel merged commit 445b3fd into glotaran:main Jan 16, 2022
@jsnel jsnel deleted the configure-sonarcloud branch January 16, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants