🚧 Disallow xarray versions breaking plotting in integration tests #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
=====================================
Coverage 84.7% 84.7%
=====================================
Files 81 81
Lines 4603 4603
Branches 849 849
=====================================
Hits 3902 3902
Misses 559 559
Partials 142 142 Continue to review full report at Codecov.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
0.20.0release introduced a bug breaking plotting in integration tests (see also #892 ).By now this bug has been fixed but no new version of
xarrayhas yet been released, so we should disallow the breaking versions.If a fixed version has been released we can think of raising the minimal version.
Change summary
Checklist