🧹 Move megacomplex integration tests from root level to megacomplexes #894

s-weigand · 2021-11-07T17:58:37Z

Having those tests at gloratan/tests would suggest that we are testing the functionality of gloratan/init.py.
Since the tests are integration tests for combinations of different megacomplexes, glotaran/builtin/megacomplexes is a more appropriate place for them.

Change summary

🧹 Move megacomplex integration tests from root level to megacomplexes

Checklist

✔️ Passing the tests (mandatory for all PR's)

github-actions · 2021-11-07T17:58:50Z

👈 Launch a binder notebook on branch s-weigand/pyglotaran/move-toplevel-test-folder

codecov · 2021-11-07T18:03:01Z

Codecov Report

Merging #894 (ade1dac) into main (8ae1b90) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #894   +/-   ##
=====================================
  Coverage   84.7%   84.7%           
=====================================
  Files         81      81           
  Lines       4603    4603           
  Branches     849     849           
=====================================
  Hits        3902    3902           
  Misses       559     559           
  Partials     142     142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae1b90...ade1dac. Read the comment docs.

jsnel

👍

joernweissenborn

lgtm

Having those tests at 'gloratan/tests' would suggest that we are testing the functionality of gloratan/__init__.py. Since the tests are integration tests for combinations of different megacomplexes, 'glotaran/builtin/megacomplexes' is a more appropriate place for them.