-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇 Speedup PR benchmark #785
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #785 +/- ##
=======================================
Coverage 83.9% 83.9%
=======================================
Files 75 75
Lines 4185 4185
Branches 752 752
=======================================
Hits 3512 3512
Misses 538 538
Partials 135 135 Continue to review full report at Codecov.
|
The benchmarking time is down to ~3min 🎉 |
This way we a comment edit history
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Benchmark is done. Checkout the benchmark result page. Benchmark diffParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🕐++
* 🚇 Only run base compare commit and last HEAD commit on PR benchmark * 👌 Update comment w/o deleting the last one (comment should have an 'edit' history)
Running benchmarks on PRs takes forever to get feedback (~1h e.g. here) since it benchmarks each commit in between.
The most important information are the benchmark of the last release and the current commit before merging.
Thus we can omit running the benchmarks for all steps in between.
If more insight is needed at which specific commit in a PR a performance regression occurred it can always be run locally.
Change summary
v0.4.0
) and lastHEAD
commit on PR benchmarkChecklist