Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix interrogate usage #781

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

s-weigand
Copy link
Member

Currently the way interrogate is run by pre-commit it auto-discovers *.py files in the repo root.
This can lead to errors with venvs.

Change summary

  • 🩹🔧 Changed interrogate hook to only run on glotaran folder
  • 👌🚧 Raised interrogate threshold for 52% to 55% (current value 56.1%)

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner August 20, 2021 12:58
@s-weigand s-weigand added the Type: Tooling Tools used for the project (CI, CD, docs etc.) label Aug 20, 2021
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-interrogate

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #781 (dbff435) into staging (998bad5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           staging    #781   +/-   ##
=======================================
  Coverage     83.9%   83.9%           
=======================================
  Files           75      75           
  Lines         4185    4185           
  Branches       752     752           
=======================================
  Hits          3512    3512           
  Misses         538     538           
  Partials       135     135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998bad5...dbff435. Read the comment docs.

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [dc00e6da]       [dbff435e]
     <v0.4.0>                   
-      48.6±0.3ms       36.2±0.3ms     0.75  BenchmarkOptimize.time_optimize(False, False, False)
-         268±2ms       42.3±0.7ms     0.16  BenchmarkOptimize.time_optimize(False, False, True)
-      71.4±0.4ms       59.6±0.1ms     0.83  BenchmarkOptimize.time_optimize(False, True, False)
       73.8±0.5ms        78.3±20ms     1.06  BenchmarkOptimize.time_optimize(False, True, True)
       49.4±0.8ms       47.0±0.4ms     0.95  BenchmarkOptimize.time_optimize(True, False, False)
-         270±6ms         53.2±5ms     0.20  BenchmarkOptimize.time_optimize(True, False, True)
       70.7±0.7ms       71.2±0.5ms     1.01  BenchmarkOptimize.time_optimize(True, True, False)
       73.5±0.7ms       76.5±0.4ms     1.04  BenchmarkOptimize.time_optimize(True, True, True)
             179M             178M     1.00  IntegrationTwoDatasets.peakmem_create_result
             198M             196M     0.99  IntegrationTwoDatasets.peakmem_optimize
-         225±2ms          182±2ms     0.81  IntegrationTwoDatasets.time_create_result
-         4.72±0s       1.51±0.03s     0.32  IntegrationTwoDatasets.time_optimize

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsnel jsnel merged commit a464ec3 into glotaran:staging Aug 20, 2021
@s-weigand s-weigand deleted the fix-interrogate branch August 20, 2021 22:47
jsnel pushed a commit that referenced this pull request Sep 16, 2021
* 🩹 🔧 Only run interrogate on glotaran folder

* 👌 🚧 Raised interrogate threshold for 52% to 55% (current value 56.1%)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants