Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Compare benchmarks to 0.4.0 instead if upstream/main #728

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

s-weigand
Copy link
Member

Follow up PR for #723

Change summary

  • The benchmark comment bot now compares against 0.4.0

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner June 29, 2021 18:15
@s-weigand s-weigand added the Type: Tooling Tools used for the project (CI, CD, docs etc.) label Jun 29, 2021
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-bench

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #728 (af7a512) into main (2441246) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #728   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files         79      79           
  Lines       4024    4024           
  Branches     706     706           
=====================================
  Hits        3291    3291           
  Misses       606     606           
  Partials     127     127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2441246...af7a512. Read the comment docs.

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

All benchmarks:

       before           after         ratio
     [dc00e6da]       [af7a512d]
     <v0.4.0>                   
             177M             176M     1.00  IntegrationTwoDatasets.peakmem_create_result
             195M             195M     1.00  IntegrationTwoDatasets.peakmem_optimize
          235±3ms          244±1ms     1.04  IntegrationTwoDatasets.time_create_result
+      4.85±0.01s          6.16±0s     1.27  IntegrationTwoDatasets.time_optimize

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsnel jsnel merged commit b953319 into glotaran:main Jul 2, 2021
@s-weigand s-weigand deleted the fix-bench branch July 2, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants