Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš‡ Raised benchmark timeout to 5min #724

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

s-weigand
Copy link
Member

In #715 the benchmarks failed because they timed out after 60 seconds so to get results we need to raise the timeout.

Change summary

  • Raised PR benchmark to 300 seconds

Checklist

  • βœ”οΈ Passing the tests (mandatory for all PR's)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 26, 2021

Sourcery Code Quality Report

βœ… Β Merging this PR will increase code quality in the affected files by 2.47%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.17 ⭐ 0.17 πŸ‘Ž
Method Length 28.33 ⭐ 26.71 ⭐ -1.62 πŸ‘
Working memory 6.45 πŸ™‚ 5.71 ⭐ -0.74 πŸ‘
Quality 83.02% ⭐ 85.49% ⭐ 2.47% πŸ‘
Other metrics Before After Change
Lines 57 61 4
Changed files Quality Before Quality After Quality Change
benchmark/benchmarks/integration/ex_two_datasets/benchmark.py 83.02% ⭐ 85.49% ⭐ 2.47% πŸ‘

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
benchmark/benchmarks/integration/ex_two_datasets/benchmark.py IntegrationTwoDatasets.setup 0 ⭐ 95 πŸ™‚ 10 😞 69.70% πŸ™‚ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • πŸ™‚ good
  • 😞 poor
  • β›” very poor

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions
Copy link
Contributor

Binder πŸ‘ˆ Launch a binder notebook on branch s-weigand/pyglotaran/asv-raise-timeout

@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #724 (3235098) into main (9bd8732) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #724   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files         79      79           
  Lines       4024    4024           
  Branches     706     706           
=====================================
  Hits        3291    3291           
  Misses       606     606           
  Partials     127     127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9bd8732...3235098. Read the comment docs.

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff

All benchmarks:

       before           after         ratio
     [9bd8732b]       [32350983]
             183M             176M     0.96  IntegrationTwoDatasets.peakmem_create_result
             202M             201M     1.00  IntegrationTwoDatasets.peakmem_optimize
          177Β±2ms          175Β±4ms     0.99  IntegrationTwoDatasets.time_create_result
        4.40Β±0.1s       4.37Β±0.02s     0.99  IntegrationTwoDatasets.time_optimize

@s-weigand s-weigand merged commit 2e7421b into glotaran:main Jun 26, 2021
@s-weigand s-weigand deleted the asv-raise-timeout branch June 26, 2021 23:18
jsnel pushed a commit that referenced this pull request Aug 14, 2021
jsnel pushed a commit to jsnel/pyglotaran that referenced this pull request Aug 14, 2021
jsnel pushed a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant