-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Update issue and PR templates #692
Conversation
If you want to try it out I temporarily changed the default branch of my fork to this branch and allowed issues. The assigning and label functionality might not work there though, since there are different labels and it isn't part of the glotaran orga. |
Hmm, the issue templates work fine, but the PR templates don't... need some investigating. |
Ok sadly there isn't a nice UI selector for PR templates and there is for issue templates, but it was requested multiple times:
And was added to the requested feature list. To use a specific PR template you need to add Also, It looks like the PR templates don't support the special template headers that issue templates support, they are supported via query parameters. So until GitHub properly support multiple templates with easy usage we need a default template ( The question now is, do we want to also keep custom templates and add a guide to the docs on how to use them (I at least would use them) or just delete them again? |
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 79 79
Lines 3920 3920
Branches 693 693
=====================================
Hits 3206 3206
Misses 594 594
Partials 120 120 Continue to review full report at Codecov.
|
Changed templates to differentiate better between different types of issues and PRs. Ref: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests
since they aren't supported by PR templates.
c5d67ac
to
8a4055e
Compare
Kudos, SonarCloud Quality Gate passed! |
And here are some test PRs with the template: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks.
Moved issue and PR templates to the proper folders and changed templates to differentiate better between different types of issues and PRs.
Ref:
GitHub communities docs
Testing
Passing the tests is mandatory.
Related issue
#608