-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1474 - add fields to result object - correct calculation of number of clps. #1484
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Which is more consistent with 0.7 API
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1484 +/- ##
=======================================
Coverage 85.2% 85.2%
=======================================
Files 91 91
Lines 3735 3756 +21
Branches 726 734 +8
=======================================
+ Hits 3184 3203 +19
- Misses 438 440 +2
Partials 113 113 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested ok.
Closes #1474
Fixes #1474
additional_penalty
to the result object and renamesnr_clp
back tonumber_of_clps
.