Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧🚀 Prepare 0.7.0 release #1250

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Feb 19, 2023

This PR contains the preparation for the 0.7.0 and should be the last thing merged in before we create the release.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 19, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.34%.

Quality metrics Before After Change
Complexity 4.62 ⭐ 3.75 ⭐ -0.87 👍
Method Length 101.65 🙂 75.13 🙂 -26.52 👍
Working memory 6.94 🙂 7.19 🙂 0.25 👎
Quality 68.72% 🙂 73.06% 🙂 4.34% 👍
Other metrics Before After Change
Lines 650 380 -270
Changed files Quality Before Quality After Quality Change
glotaran/__init__.py 92.05% ⭐ 92.05% ⭐ 0.00%
glotaran/builtin/io/yml/yml.py 71.54% 🙂 71.25% 🙂 -0.29% 👎
glotaran/deprecation/modules/builtin_io_yml.py 60.06% 🙂 95.15% ⭐ 35.09% 👍
glotaran/deprecation/modules/test/__init__.py 72.61% 🙂 70.82% 🙂 -1.79% 👎
glotaran/deprecation/modules/test/test_builtin_io_yml.py 65.10% 🙂 73.00% 🙂 7.90% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
glotaran/builtin/io/yml/yml.py YmlProjectIo.save_model 15 🙂 117 🙂 13 😞 47.50% 😞 Extract out complex expressions
glotaran/builtin/io/yml/yml.py YmlProjectIo.save_result 2 ⭐ 142 😞 7 🙂 68.41% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/prepare-0.7.0-release

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.6.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [6c3c390e]       [b7af7fe6]
     <v0.6.0>                   
!        50.1±3ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
!        52.1±1ms           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
!      49.5±0.8ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
!       53.0±10ms           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
!        63.1±1ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
!       66.8±30ms           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
!        63.1±1ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
!       68.4±30ms           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             205M             208M     1.01  IntegrationTwoDatasets.peakmem_optimize
-      1.88±0.06s       1.20±0.04s     0.64  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [b7af7fe6]       [45126cf8]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             208M             208M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.20±0.04s       1.15±0.05s     0.96  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: -0.1 ⚠️

Comparison is base (b7af7fe) 88.4% compared to head (45126cf) 88.3%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1250     +/-   ##
=======================================
- Coverage   88.4%   88.3%   -0.1%     
=======================================
  Files        107     107             
  Lines       5147    5122     -25     
  Branches     854     847      -7     
=======================================
- Hits        4550    4525     -25     
  Misses       479     479             
  Partials     118     118             
Impacted Files Coverage Δ
glotaran/builtin/io/yml/yml.py 85.2% <ø> (-0.4%) ⬇️
glotaran/deprecation/modules/builtin_io_yml.py 100.0% <ø> (ø)
glotaran/__init__.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand s-weigand force-pushed the prepare-0.7.0-release branch from c20e641 to e229a93 Compare March 16, 2023 20:46
@jsnel
Copy link
Member

jsnel commented Mar 20, 2023

Slightly delayed due to deadlines and sickness, shall we re-schedule for coming weekend?

@jsnel jsnel requested review from joernweissenborn and jsnel March 23, 2023 23:53
@joernweissenborn joernweissenborn marked this pull request as ready for review March 24, 2023 13:46
jsnel
jsnel previously approved these changes Mar 26, 2023
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my side. All automated testing is passing. We have not done all possible manual testing, but if we find minor issues with that we can always patch it in 0.7.1. As such it should be possible to release it now @s-weigand and @joernweissenborn.

@jsnel
Copy link
Member

jsnel commented Mar 26, 2023

And @s-weigand the honors of making a release are all yours this time, after all this is the release dedicated to your MSc Thesis! :D

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@s-weigand s-weigand merged commit 9adf4a4 into glotaran:main Mar 27, 2023
@s-weigand s-weigand deleted the prepare-0.7.0-release branch March 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants