-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚇🩹 Fix wrong comparison in pr_benchmark workflow #1097
Conversation
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.6.0 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Codecov Report
@@ Coverage Diff @@
## main #1097 +/- ##
=====================================
Coverage 87.1% 87.1%
=====================================
Files 101 101
Lines 5339 5339
Branches 995 995
=====================================
Hits 4654 4654
Misses 530 530
Partials 155 155 Continue to review full report at Codecov.
|
3728a0f
to
5061266
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
In #1060 we just found that there is an error in the comparison of the last tag and the main branch in the
pr_benchmark
workflow. Instead of comparing the last tag to main, it compares it against the PR HEADChange summary
Checklist