🩹 Fix degraded label with nesting over 2

glotaran · May 20, 2022 · a051427 · a051427
1 parent 2e44162
commit a051427
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/glotaran/parameter/parameter_group.py b/glotaran/parameter/parameter_group.py
@@ -490,6 +490,7 @@ def all(
         """
         root = f"{root}{self.label}{separator}" if root is not None else ""
         for label, p in self._parameters.items():
+            p.full_label = f"{root}{label}"
             yield (f"{root}{label}", p)
         for _, l in self.items():
             yield from l.all(root=root, separator=separator)

diff --git a/glotaran/parameter/test/test_parameter_group.py b/glotaran/parameter/test/test_parameter_group.py
@@ -93,6 +93,9 @@ def test_parameter_group_from_dict_nested():
 
     assert params.get("kinetic.j.1").full_label == "kinetic.j.1"
 
+    roundtrip_df = ParameterGroup.from_dataframe(params.to_dataframe()).to_dataframe()
+    assert all(roundtrip_df.label == params.to_dataframe().label)
+
 
 def test_parameter_group_to_array():
     params = """