Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor with project API #4

Merged
merged 24 commits into from
Mar 1, 2023
Merged

♻️ Refactor with project API #4

merged 24 commits into from
Mar 1, 2023

Conversation

s-weigand
Copy link
Member

This change refactors the case studies to use the project API and did lead to some improvements in the project API itself.

In addition, it cleans up the model and parameter files as well as notebooks.
Further improvements like using glotaran generated clp guides and explaining the smoothing due clp_relations will follow in a different PR.

Change summary

s-weigand and others added 24 commits February 27, 2023 18:27
 🔧Only check that notebooks run not the output (nbval fails on plots)
@s-weigand
Copy link
Member Author

For easier review here are the PDFs generated from the notebooks on the current main branch (see the action workflow ).
pdfs.zip

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this massive cleanup!

I see some of the (table) rending in the notebooks is still a bit off, but this can be tackled in a future PR. The intention of the PDF is to be able to judge if the plots change significantly and for that it works great!

@jsnel jsnel merged commit 87becb8 into glotaran:main Mar 1, 2023
@s-weigand s-weigand deleted the refactor-with-project-api branch March 3, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants