Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix irf location selection for irfs with multiple components #32

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

s-weigand
Copy link
Member

Follow up PR for #30

Since the DPSI case study was broken until glotaran/pyglotaran#797 we didn't see that the plottings breaks.

I tested it against all the notebooks on my notebook branch and examples on pyglotaran-examples main branch.

Change summary

  • Fix irf location selection for irfs with multiple components

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner September 14, 2021 22:34
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/fix-multi-irf

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #32 (a19f001) into main (86341af) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   5.93%   5.93%           
=====================================
  Files         12      12           
  Lines        354     354           
  Branches      41      41           
=====================================
  Hits          21      21           
  Misses       333     333           
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_traces.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86341af...a19f001. Read the comment docs.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🩹

@jsnel jsnel merged commit 9558b85 into glotaran:main Sep 15, 2021
@s-weigand s-weigand deleted the fix-multi-irf branch September 16, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants