Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix incompatibility of plot_data_and_fits with matplotlib>=3.8 #275

Merged
merged 6 commits into from
Jun 30, 2024

Conversation

s-weigand
Copy link
Member

This change fixes that plot_data_and_fits (called by plot_fitted_traces) crashes with

AttributeError: '_process_plot_var' args object has no attribute 'prop_cycler'

When matplotlib>=3.8 is installed.

It also adds a CI test job using the minimum required version.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner June 30, 2024 12:40
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/matplot_lib_compat

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (b880df9) to head (515ff7e).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pyglotaran_extras/plotting/plot_traces.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   44.77%   45.24%   +0.47%     
==========================================
  Files          27       27              
  Lines        1043     1052       +9     
  Branches      162      163       +1     
==========================================
+ Hits          467      476       +9     
  Misses        568      568              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this yesterday, thanks for the quick fix.

@s-weigand s-weigand merged commit f8a2bc9 into glotaran:main Jun 30, 2024
31 checks passed
@s-weigand s-weigand deleted the matplot_lib_compat branch June 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants