Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve plot_doas default legend_format_string #151

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Feb 24, 2023

Looks like matplotlib can render tex math style without activating latex nowadays so we can replace "{label}: v={frequency:.0f}, Γ={rate:.1f}" with r"{label}: $\nu$={frequency:.0f}, $\gamma$={rate:.1f}" (changing the gamma to the lower case version was on request of @ism200 ).

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner February 24, 2023 10:59
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 24, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 8.80 🙂 8.80 🙂 0.00
Method Length 290.50 ⛔ 290.50 ⛔ 0.00
Working memory 23.55 ⛔ 23.55 ⛔ 0.00
Quality 28.71% 😞 28.71% 😞 0.00%
Other metrics Before After Change
Lines 168 168 0
Changed files Quality Before Quality After Quality Change
pyglotaran_extras/plotting/plot_doas.py 28.71% 😞 28.71% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyglotaran_extras/plotting/plot_doas.py plot_doas 9 🙂 454 ⛔ 24 ⛔ 27.56% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@s-weigand s-weigand requested a review from jsnel February 24, 2023 10:59
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/improve-doas-legend

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 44.79% // Head: 44.79% // No change to project coverage 👍

Coverage data is based on head (19f98c1) compared to base (0ed9a7b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   44.79%   44.79%           
=======================================
  Files          29       29           
  Lines         942      942           
  Branches      134      134           
=======================================
  Hits          422      422           
  Misses        513      513           
  Partials        7        7           
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_doas.py 26.92% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

From the Greek Alphabet:
Α α, Β β, Γ γ, Δ δ, Ε ε, Ζ ζ, Η η, Θ θ, Ι ι, Κ κ, Λ λ, Μ μ, Ν ν, Ξ ξ, Ο ο, Π π, Ρ ρ, Σ σ/ς, Τ τ, Υ υ, Φ φ, Χ χ, Ψ ψ, Ω ω.
Ref: https://en.wikipedia.org/wiki/Greek_alphabet
@s-weigand s-weigand merged commit b1cceca into glotaran:main Feb 24, 2023
@s-weigand s-weigand deleted the improve-doas-legend branch February 24, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants