-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 Add option to deactivate data/residual plotting in overview plots #118
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.39%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov ReportBase: 40.66% // Head: 40.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 40.66% 40.61% -0.06%
==========================================
Files 24 24
Lines 718 719 +1
Branches 98 98
==========================================
Hits 292 292
- Misses 426 427 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the future we can think about a more efficient use of the real estate rather than printing skipped in rather large font. ;)
Especially for big datasets the 2D plots (data/residual) in
plot_overview
orplot_simple_overview
can take a long time (up to 1 minute). This change addsNone
as a possible value forshow_data
which allows switching off this part of the plot altogether, instead "Skipped" will be written to the middle of the axis (subplot).The following code will generate the plot below it
Change summary
Checklist