-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Backport of example notebooks #103
Conversation
The backported DOAS example notebook from staging
The backported (with some modifications) spectral constraints example notebook
Backported the example of the analysis of simulated three dataset with dispersion. Updated the model.yml to address a deprecation warning.
9054041
to
01f05a5
Compare
01f05a5
to
cd5a422
Compare
41011ac
to
e60689e
Compare
This is needed sp 'example-list' gets set
♻️ Rename files to fit name used in notebook run script
3b7f8e3
to
0c7b916
Compare
Fix inconsistent formatting between notebooks
🧹 Fix deprecated model spec
f0c675c
to
c644714
Compare
10e4162
to
12a2b40
Compare
For easier comparison
🧙 Sourcery is reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We worked on it together and it doesn't look as naturally grown as before and will improve comparison to staging a lot easier due to the similar style.
This PR replaces the scripts used for validation with notebooks.
The notebooks were taken from staging, and then adapted to match the (output of) the scripts again.
The notebooks on staging themselves were early ports of the scripts on main, so the circle is round again.
scripts [main] -> notebooks [staging] -> notebooks [main]
Change summary
Checklist