Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Backport of example notebooks #103

Merged
merged 29 commits into from
Jun 8, 2024

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Jun 7, 2024

This PR replaces the scripts used for validation with notebooks.

The notebooks were taken from staging, and then adapted to match the (output of) the scripts again.
The notebooks on staging themselves were early ports of the scripts on main, so the circle is round again.

scripts [main] -> notebooks [staging] -> notebooks [main]

Change summary

  • ✨ Ported all scripts to notebooks
  • 👷Add CI infrastructure files to run notebooks
  • 🧹Various cleanup actions

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

jsnel added 3 commits June 7, 2024 21:34
The backported DOAS example notebook from staging
The backported (with some modifications) spectral constraints example notebook
Backported the example of the analysis of simulated three dataset with dispersion.
Updated the model.yml to address a deprecation warning.
@jsnel jsnel force-pushed the backporting_nbs_from_staging branch 2 times, most recently from 9054041 to 01f05a5 Compare June 7, 2024 22:51
@jsnel jsnel force-pushed the backporting_nbs_from_staging branch from 01f05a5 to cd5a422 Compare June 7, 2024 22:54
@jsnel jsnel requested a review from s-weigand June 7, 2024 22:54
@s-weigand s-weigand force-pushed the backporting_nbs_from_staging branch from 41011ac to e60689e Compare June 7, 2024 23:52
@s-weigand s-weigand force-pushed the backporting_nbs_from_staging branch from 3b7f8e3 to 0c7b916 Compare June 8, 2024 01:01
@s-weigand s-weigand force-pushed the backporting_nbs_from_staging branch from f0c675c to c644714 Compare June 8, 2024 11:08
@s-weigand s-weigand force-pushed the backporting_nbs_from_staging branch from 10e4162 to 12a2b40 Compare June 8, 2024 11:59
@s-weigand s-weigand mentioned this pull request Jun 8, 2024
1 task
@jsnel jsnel marked this pull request as ready for review June 8, 2024 18:04
Copy link
Contributor

sourcery-ai bot commented Jun 8, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We worked on it together and it doesn't look as naturally grown as before and will improve comparison to staging a lot easier due to the similar style.

@s-weigand s-weigand merged commit 85af3de into glotaran:main Jun 8, 2024
19 checks passed
@jsnel jsnel mentioned this pull request Jun 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants