add AuthorizerFactory and implementations #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orizerFactory, and ClientCredentialsAuthorizerFactory
aaschaer
requested review from
ada-globus,
derek-globus,
kurtmckee and
sirosen
as code owners
sirosen
reviewed
May 17, 2024
|
|
||
| return token_data | ||
|
|
||
| def store_token_response(self, token_res: OAuthTokenResponse) -> None: |
There was a problem hiding this comment.
What are the callers for this method?
I'm noticing that the renewing authorizers bypass it (presumably, so that they don't blow the cache), so I'm guessing this is used as part of login flows.
Can we distinguish the name from the token storage method, so that the two are not likely to be confused?
There was a problem hiding this comment.
This will probably only be called by a GlobusApp after its had a user complete a login flow (or someone trying to do GlobusApp like things on their own)
store_token_response_and_clear_cache seems reasonable to me?
Co-authored-by: Stephen Rosen <[email protected]>
sirosen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut: https://app.shortcut.com/globus/story/30767/sdk-authorizerfactory
Change Summary (all in experimental):
AuthorizerFactoryan interface for getting authorizers from aValidatingTokenStorageAccessTokenAuthorizerFactory,RefreshTokenAuthorizerFactory, andClientCredentialsAuthorizerFactorywhich implementAuthorizerFactoryand createAccessTokenAuthorizerRefreshTokenAuthorizerandClientCredentialsAuthorizerrespectively📚 Documentation preview 📚: https://globus-sdk-python--985.org.readthedocs.build/en/985/