-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validate_flow
operation to FlowsClient
#979
Add validate_flow
operation to FlowsClient
#979
Conversation
Signed-off-by: Ada <[email protected]>
Signed-off-by: Ada <[email protected]>
@@ -46,14 +46,14 @@ def create_flow( | |||
additional_fields: dict[str, t.Any] | None = None, | |||
) -> GlobusHTTPResponse: | |||
""" | |||
Create a Flow | |||
Create a flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a style-guide for this. We started using emphasis (boldface, IIRC?) in some of the docs for flow
, run
, timer
, and other proper nouns which are easily confused with service names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think the way I'd phrase it is roughly:
Entities (e.g., flow, run, action, action provider) are lowercase and first appearance is set off as a "term" in whatever paradigm a given document uses; for the docs site, we use bold
Is there such a paradigm—or related prior-art—in the SDK docs? If so, happy to make consistent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like us to hold this change until there's a Flows service release to put that validate route out there. When the SDK or CLI "run ahead", it produces a slightly strange situation if we release.
@@ -46,14 +46,14 @@ def create_flow( | |||
additional_fields: dict[str, t.Any] | None = None, | |||
) -> GlobusHTTPResponse: | |||
""" | |||
Create a Flow | |||
Create a flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a style-guide for this. We started using emphasis (boldface, IIRC?) in some of the docs for flow
, run
, timer
, and other proper nouns which are easily confused with service names.
@sirosen Yeah, wasn't planning to merge til the Flows release hits next week—and CLI will be prepped for when that occurs :) |
I added a quick copyedit commit to normalize capitalization of "flow" and "run", which appeared to be inconsistent. It's not per se part of the scope, but was very fast and relevant to matching the new docstring for
validate_flow
. If it's a significant barrier to getting this merged, I can break it into a separate PR.📚 Documentation preview 📚: https://globus-sdk-python--979.org.readthedocs.build/en/979/