Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken ScalingFailed exception construction #690

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Fix broken ScalingFailed exception construction #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4afd3
Fix broken ScalingFailed exception construction
benclifford Feb 2, 2022
f9afb35
Merge remote-tracking branch 'origin/main' into issue679-part1
benclifford Feb 15, 2022
814e3ff
Add changelog
benclifford Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions changelog.d/20220215_133045_benc_issue679_part1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
.. A new scriv changelog fragment.
..
.. Uncomment the header that is right (remove the leading dots).
..
.. New Functionality
.. ^^^^^^^^^^^^^^^^^
..
.. - A bullet item for the New Functionality category.
..
Bug Fixes
^^^^^^^^^

- When a provider raised an exception, that exception was then mishandled
and presented as an AttributeError. This handling now no longer corrupts
the exception. https://github.com/funcx-faas/funcX/issues/679
..
.. Removed
.. ^^^^^^^
..
.. - A bullet item for the Removed category.
..
.. Deprecated
.. ^^^^^^^^^^
..
.. - A bullet item for the Deprecated category.
..
.. Changed
.. ^^^^^^^
..
.. - A bullet item for the Changed category.
..
.. Security
.. ^^^^^^^^
..
.. - A bullet item for the Security category.
..
2 changes: 1 addition & 1 deletion funcx_endpoint/funcx_endpoint/executors/high_throughput/interchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ def scale_out(self, blocks=1, task_type=None):
if not internal_block:
raise (
ScalingFailed(
self.config.provider.label,
self.provider.label,
"Attempts to provision nodes via provider has failed",
)
)
Expand Down