Update jenkins script for building packages #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
no-news-is-good-news
khk-globus
reviewed
Feb 14, 2025
Comment on lines
34
to
36
| env.BRANCH_NAME = params.BRANCH_OR_TAG | ||
| env.BUILD_FOR_STABLE = params.BUILD_FOR_STABLE | ||
| env.TAG_NAME = "${env.BRANCH_NAME}" |
There was a problem hiding this comment.
I've forgotten the later-on Groovy script innards; would it behoove us to set one OR the other?
Meanwhile, if setting both (in direct answer to my question ☝️), perhaps clearer to colocate BRANCH_NAME and TAG_NAME since they're to be the same value. Consider:
env.BRANCH_NAME = params.BRANCH_OR_TAG
env.TAG_NAME = params.BRANCH_OR_TAG
env.BUILD_FOR STABLE = params.BUILD_FOR_STABLEThere was a problem hiding this comment.
Same reason - I wasn't sure if TAG_NAME is used later, so left it set just in case. I made a bit more clearer as you suggested but I'll also look to see if TAG_NAME matters.
LeiGlobus
force-pushed
the
jenkins311
branch
from
a347184 to
ddcce2f
Compare
khk-globus
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last few builds have failed due to some issues, this update (should) improve it.
After it's merged, I'll also update the default branch in Jenkins to main.