Bugfix: start JobStatusPoller at engine start #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent refactor to move the JobStatusPoller thread initialization to the
`GlobusComputeEngine.__init__` method missed that endpoints are often
daemonized. Daemonization only allows the fork()ing thread to survive.
Fix: Move the JSP thread creation back to the GCE's `.start()` method, since
this method is invoked *after* the daemonization. This time, cement the
expectation with a test.
Reference:
- #1779 (as part of [sc-37953])
- 393b410
LeiGlobus
approved these changes
Feb 13, 2025
Hah. That's exactly what I thought I did! But clearly missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactor to move the JobStatusPoller thread initialization to the
GlobusComputeEngine.__init__method missed that endpoints are often daemonized. Daemonization only allows the fork()ing thread to survive.Fix: Move the JSP thread creation back to the GCE's
.start()method, since this method is invoked after the daemonization. This time, cement the expectation with a test.Reference:
Type of change