Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Client.auth_client attribute #1776

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

rjmello
Copy link
Member

@rjmello rjmello commented Jan 27, 2025

Description

This attribute is only used by the EndpointManager, which will instead instantiate its own AuthClient.

Type of change

  • Code maintenance/cleanup

khk-globus
khk-globus previously approved these changes Jan 27, 2025
Copy link
Contributor

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestion, but not a blocker.

This attribute is only used by the `EndpointManager`, which will instead
instantiate its own `AuthClient`.
@rjmello rjmello force-pushed the deprecate-auth-client-attr branch from a63b17c to b81e271 Compare January 27, 2025 21:52
@rjmello rjmello merged commit ee76ed4 into main Jan 27, 2025
21 checks passed
@rjmello rjmello deleted the deprecate-auth-client-attr branch January 27, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants