Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Parsl version req from 2025.1.6 to 2025.1.20 #1771

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

yadudoc
Copy link
Collaborator

@yadudoc yadudoc commented Jan 22, 2025

Description

There's a version dependency conflict currently between parsl and globus-compute-endpoint, this version bump fixes that.

For a user trying to use Parsl with the new optional extra that allows task submission of Globus Compute, we currently have a version dependency bug: the latest globus-compute-endpoint==2.24.0 pins parsl to 2025.1.6 while `parsl

=2025.1.20` is required to use the new functionality.

Reported by @christopherwharrop-noaa

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Code maintenance/cleanup

@chris-janidlo
Copy link
Contributor

chris-janidlo commented Jan 22, 2025

Could we change the original to a lower bound instead of pinning to a higher version? Or in other words, is there anything preventing the older parsl version from working? (I know we usually pin to specific versions, but in this case we aren't bumping because of new features in our code, but because of new features in parsl code)

@yadudoc yadudoc force-pushed the update_parsl_version_req branch from a4e8894 to 7e29826 Compare January 24, 2025 20:02
@yadudoc
Copy link
Collaborator Author

yadudoc commented Jan 24, 2025

@chris-janidlo I've updated the version requirements to allow the last few versions. Explicit pinning does come with it's own troubles, but without Parsl following semVer it's hard to go back to more relaxed bounds. This seems like a reasonable middle ground.

@yadudoc yadudoc force-pushed the update_parsl_version_req branch 2 times, most recently from 928a74a to 4125fdb Compare January 24, 2025 20:52
* There's a version dependency conflict currently between parsl and globus-compute-endpoint, this version bump fixes that.
* For a user trying to use Parsl with the new optional extra that allows
 task submission of Globus Compute, we currently have a version dependency
 bug: the latest `globus-compute-endpoint==2.24.0` pins parsl to `2025.1.6`
 while `parsl==2025.1.20` is required to use the new functionality.
@yadudoc yadudoc force-pushed the update_parsl_version_req branch from 4125fdb to 561b1c7 Compare January 24, 2025 20:53
Copy link
Contributor

@chris-janidlo chris-janidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chris-janidlo chris-janidlo merged commit 4aa8440 into main Jan 27, 2025
21 checks passed
@chris-janidlo chris-janidlo deleted the update_parsl_version_req branch January 27, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants