Add request_id to ComputeFuture._metadata #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
no-news-is-good-news
The main change is the `fut._metadata` dictionary update in `executor.py` in the happy and non-happy paths. This suggested a change in the fixtures of the tests, which resulted in a larger than expected set of test-changes. But it's all in service to the 2 `_metadata` hunk changes.
khk-globus
force-pushed
the
add_request_id_to_futures
branch
from
9cb97b4 to
a1ce40c
Compare
rjmello
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is the
fut._metadatadictionary update inexecutor.pyin the happy and non-happy paths. This suggested a change in the fixtures of the tests, which resulted in a larger than expected set of test-changes. But it's all in service to the 2_metadatahunk changes.Type of change