Apply linear backoff strategy to Client smoke tests #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying a uniform linear backoff strategy with a 60-second timeout improves test stability and simplifies debugging.
rjmello
requested review from
yadudoc,
ryanchard,
chris-janidlo,
joshbryan-globus,
khk-globus and
LeiGlobus
khk-globus
approved these changes
Dec 9, 2024
LeiGlobus
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Yes, I like the exponential and retries. A lot more effort than my 1 line change to increase to 60 in the past which appeared to reduce incidence but not eliminate them.
Using the executor would be ok but we still need to use a timeout. If the TMEP is unresponsive after a couple of minutes (with retries), I think we should still hear about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applying a uniform linear backoff strategy with a 60-second timeout improves test stability and simplifies debugging.
Type of change